Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fromSb3: Fix loading component-based pen color blocks; document shadow blocks' fields more carefully #145

Merged
merged 3 commits into from
Jun 17, 2024
Merged

fromSb3: Fix loading component-based pen color blocks; document shadow blocks' fields more carefully #145

merged 3 commits into from
Jun 17, 2024

Commits on May 30, 2024

  1. fromSb3: hard-code pen_menu_colorParam fix 

    Also improves the clarity of some nearby comments.
    @towerofnix
    towerofnix committed May 30, 2024
    Configuration menu
    Copy the full SHA
    3795976 View commit details
    Browse the repository at this point in the history

  2. sb3: document which blocks shadow blocks are used by in field map 

    Of note, only pen_menu_colorParam requires special behavior due
to a mismatch between the shadow block's field name and the using
blocks' input names.
    @towerofnix
    towerofnix committed May 30, 2024
    Configuration menu
    Copy the full SHA
    07ff415 View commit details
    Browse the repository at this point in the history

  3. update compilesb3 snapshot test 

    Essentially just adds the pen extension to the blocks tested.
The internal project.json is pretty-printed with JSON.stringify
for slightly easier git committing (though the sb3 is still
committed as a binary zip file).
    @towerofnix
    towerofnix committed May 30, 2024
    Configuration menu
    Copy the full SHA
    6145e1e View commit details
    Browse the repository at this point in the history