-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create CLI that can convert sb3 to leopard or leopard-zip #129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really awesome work, thank you!!
We left a bunch of comments, but they're mostly touch-ups for the code, and should be pretty quick to address. We also filed two issues following up this pull request, and did those before reviewing, to get some familiarity with the structure here. Check them out if you're curious: #130, #131
Thanks again! Apart from the code touch-ups, this looks great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This all looks good except for one more tweak to how asset directories are created.
@towerofnix Fixed the issue you mentioned. I also noticed that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, that's a good catch (and close call) with wcwidth
not doing what I thought it did! Thank you.
And thanks for addressing everything else, too, and for your work on this in general! This looks great. 🥳
Closes #128. Allows importing a .sb3 file and generating a leopard folder or zip directly from the CLI. I haven't implemented .sb3 output yet for the sake of time/effort. (And because .sb3 is currently the only allowed input method so it would be mostly useless.)
Example output:
I also did my best to make the errors look nice: