Fixed updateOptions with falsy value for start (#1127)

leongersen · Mar 18, 2021 · 5c07a50 · 5c07a50
1 parent b1eb5a8
commit 5c07a50
Show file tree

Hide file tree

Showing 9 changed files with 33 additions and 9 deletions.
diff --git a/CHANGELOG.MD b/CHANGELOG.MD
@@ -1,5 +1,8 @@
 # Changelog
 
+### 14.6.4 (*2021-03-18*)
+- Fixed: Fixed `updateOptions` with falsy value for `start` (#1127);
+
 ### 14.6.3 (*2020-11-19*)
 - Fixed: Fixed removing namespaced event listeners, internal listeners getting removed (#1109);
 

diff --git a/distribute/nouislider.css b/distribute/nouislider.css
@@ -1,4 +1,4 @@
-/*! nouislider - 14.6.3 - 11/19/2020 */
+/*! nouislider - 14.6.4 - 3/18/2021 */
 /* Functional styling;
  * These styles are required for noUiSlider to function.
  * You don't need to change these rules to apply your design.

diff --git a/distribute/nouislider.js b/distribute/nouislider.js
@@ -1,4 +1,4 @@
-/*! nouislider - 14.6.3 - 11/19/2020 */
+/*! nouislider - 14.6.4 - 3/18/2021 */
 (function(factory) {
     if (typeof define === "function" && define.amd) {
         // AMD. Register as an anonymous module.
@@ -13,7 +13,7 @@
 })(function() {
     "use strict";
 
-    var VERSION = "14.6.3";
+    var VERSION = "14.6.4";
 
     //region Helper Methods
 
@@ -2599,7 +2599,7 @@
 
             // Invalidate the current positioning so valueSet forces an update.
             scope_Locations = [];
-            valueSet(optionsToUpdate.start || v, fireSetEvent);
+            valueSet(isSet(optionsToUpdate.start) ? optionsToUpdate.start : v, fireSetEvent);
         }
 
         // Initialization steps

diff --git a/distribute/nouislider.min.css b/distribute/nouislider.min.css
diff --git a/distribute/nouislider.min.js b/distribute/nouislider.min.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "nouislider",
-  "version": "14.6.3",
+  "version": "14.6.4",
   "main": "distribute/nouislider.js",
   "style": "distribute/nouislider.min.css",
   "license": "MIT",

diff --git a/src/nouislider.js b/src/nouislider.js
@@ -2598,7 +2598,7 @@
 
             // Invalidate the current positioning so valueSet forces an update.
             scope_Locations = [];
-            valueSet(optionsToUpdate.start || v, fireSetEvent);
+            valueSet(isSet(optionsToUpdate.start) ? optionsToUpdate.start : v, fireSetEvent);
         }
 
         // Initialization steps

diff --git a/tests/slider.html b/tests/slider.html
@@ -69,6 +69,7 @@
 <script src="slider_errors.js"></script>
 <script src="slider_binding.js"></script>
 <script src="slider_update-numbers.js"></script>
+<script src="slider_update_options.js"></script>
 <script src="slider_three_or_more_handles.js"></script>
 <script src="slider_contained_handles.js"></script>
 <script src="slider_lookaround.js"></script>

diff --git a/tests/slider_update_options.js b/tests/slider_update_options.js
@@ -0,0 +1,20 @@
+QUnit.test("Update options", function (assert) {
+
+    document.getElementById('qunit-fixture').innerHTML = '<div class="slider"></div>';
+
+    var slider = document.getElementById('qunit-fixture').querySelector('.slider');
+
+    noUiSlider.create(slider, {
+        start: 20,
+        range: {
+            'min': 0,
+            'max': 100
+        }
+    });
+
+    slider.noUiSlider.updateOptions({ start: 3 });
+    assert.deepEqual(slider.noUiSlider.get(), "3.00");
+
+    slider.noUiSlider.updateOptions({ start: 0 });
+    assert.deepEqual(slider.noUiSlider.get(), "0.00");
+});