Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support SCIM (RFC 7643) #37

Merged
merged 16 commits into from
Jan 26, 2024
Merged

feat: support SCIM (RFC 7643) #37

merged 16 commits into from
Jan 26, 2024

Conversation

leodido
Copy link
Owner

@leodido leodido commented Jan 26, 2024 •
edited
Loading

This PR introduces:

  1. parsing modes: RFC2141 only, RFC7643 only, fallback mode (from the stricter structure to general URL structure)
  2. parsing options (which parsing mode to use, default is RFC2141-only to avoid changing the current API)
  3. SCIM (RFC7643) struct (fixes scim (rfc 7643) specific struct #32)
  4. SCIM parsing: FSM for RFC7643
  5. Fallback parsing: first try RFC7643 then fallback to RFC2141
  6. fixes to the errors outputting of the URN parser
  7. extensive test suite

@leodido
feat: introduce urn kind
bd5b6d1 
Signed-off-by: Leonardo Di Donato <[email protected]>
@leodido
feat: introduce URN parsing modes
b5f7e76 
Signed-off-by: Leonardo Di Donato <[email protected]>
@leodido
feat: introduce SCIM struct
a67edfb 
Signed-off-by: Leonardo Di Donato <[email protected]>
@leodido
feat: introduce parser options
b37cf87 
Signed-off-by: Leonardo Di Donato <[email protected]>
@leodido leodido self-assigned this Jan 26, 2024
@leodido leodido mentioned this pull request Jan 26, 2024
Closed
@leodido
feat: the URN struct can eventually point to a SCIM struct instance now
e96adc2 
Signed-off-by: Leonardo Di Donato <[email protected]>
@leodido
refactor: move SCIM schema types to their own module
fdfa639 
Signed-off-by: Leonardo Di Donato <[email protected]>
@leodido
test: check SCIM struct marshal/unmarshal works
7ad6aa8 
Signed-off-by: Leonardo Di Donato <[email protected]>
@leodido
build: upgrade deps
b6e1f89 
Signed-off-by: Leonardo Di Donato <[email protected]>
@leodido
feat: create FSM for scim parsing + FSM for fallback parsing (try sci…
d0918ce 
…m, fallback to 2141 URN machine otherwise)

Signed-off-by: Leonardo Di Donato <[email protected]>
@leodido
test: update benchmarks
02e58ca 
Signed-off-by: Leonardo Di Donato <[email protected]>
@leodido
docs: update FSM image
ef849fe 
Signed-off-by: Leonardo Di Donato <[email protected]>
@leodido
test: prepare test cases for SCIM only parsing and for fallback parsing
ca9aa03 
Signed-off-by: Leonardo Di Donato <[email protected]>
@leodido
test: provide example for SCIM only parsing
20b1814 
Signed-off-by: Leonardo Di Donato <[email protected]>
@leodido
test: test that SCIM only parsing and fallback parsing work as meant
6348924 
Signed-off-by: Leonardo Di Donato <[email protected]>
@leodido
ci: remove support for Go 1.16 and Go 1.17
2e566bb 
Signed-off-by: Leonardo Di Donato <[email protected]>
@leodido leodido marked this pull request as ready for review January 26, 2024 14:05
@leodido
docs: update README
21069b4 
Signed-off-by: Leonardo Di Donato <[email protected]>
@leodido leodido merged commit 283d0ad into master Jan 26, 2024
8 checks passed
@leodido leodido deleted the feat/scim+parsingmodes branch January 26, 2024 14:21
@t2y
Copy link
Contributor

t2y commented Jan 26, 2024

I appreciate supporting SCIM struct. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@leodido leodido

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scim (rfc 7643) specific struct
2 participants
@leodido @t2y