Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set Playlist visibility #22

Merged
merged 11 commits into from
Apr 17, 2024
Merged

Add ability to set Playlist visibility #22

merged 11 commits into from
Apr 17, 2024

Conversation

leingenm
Copy link
Owner

@leingenm leingenm commented Apr 17, 2024

Pull Request

Description

Related Issue

Checklist

Please review and check all applicable items:

  • I have tested my changes thoroughly
  • My code follows the project's coding standards and guidelines
  • I have added necessary documentation (if applicable)
  • I have updated relevant tests (if applicable)
  • I have reviewed my changes to ensure there are no unnecessary changes
  • My pull request has a descriptive title and includes a detailed description of the changes

Additional Notes

Refactored methods so they only accept DTO for playlist. Initially, I tried a less invasive approach but it led to 3 overloaded methods that significantly increase cognitive load.

Updated related tests to use DTO.

Updated Postman collections.

@leingenm leingenm linked an issue Apr 17, 2024 that may be closed by this pull request
@leingenm leingenm requested a review from daverbk April 17, 2024 15:11
@leingenm leingenm self-assigned this Apr 17, 2024
@leingenm leingenm added the enhancement New feature or request label Apr 17, 2024
@leingenm leingenm marked this pull request as ready for review April 17, 2024 15:21
Co-authored-by: RomanMager <[email protected]>
@daverbk daverbk merged commit 45f3338 into main Apr 17, 2024
3 checks passed
@daverbk daverbk deleted the issue-18 branch April 17, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add ability to set playlist visibility
2 participants