Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerize the app #21

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Dockerize the app #21

merged 3 commits into from
Aug 29, 2024

Conversation

daverbk
Copy link
Collaborator

@daverbk daverbk commented Apr 15, 2024

Pull Request

Description

Add Dockerfile to build images from

Related Issue

#19

Checklist

Please review and check all applicable items:

  • I have tested my changes thoroughly
  • My code follows the project's coding standards and guidelines
  • I have reviewed my changes to ensure there are no unnecessary changes
  • My pull request has a descriptive title and includes a detailed description of the changes

Additional Notes

I believe this pull request should hang for a week as I need to check if we need to push docker images to docker hub on pushes to main (it depends on the way we are going to deploy to aws). In case it's going to be required I'll add a workflow related to building and pushing docker image to docker hub :)

Screenshots

image

@daverbk daverbk added the enhancement New feature or request label Apr 15, 2024
@daverbk daverbk requested a review from leingenm April 15, 2024 07:54
@daverbk daverbk self-assigned this Apr 15, 2024
@daverbk daverbk linked an issue Apr 15, 2024 that may be closed by this pull request
@daverbk daverbk changed the title Dockerize app Dockerize the app Apr 15, 2024
@daverbk
Copy link
Collaborator Author

daverbk commented Jun 16, 2024

TO DOs:

  • add different profiles for application.yamls
  1. dev
  2. prod
  • resolve the keystore issue during the deployment

  • add a workflow with a manual trigger that will

  1. get the keystore from s3
  2. copy it inside the image
  3. push the image to ecr
  4. pull the ecr by the ec2 instance
  5. start a container with the new image on the ec2 instance

@leingenm leingenm merged commit be7f5f7 into main Aug 29, 2024
3 checks passed
@leingenm leingenm deleted the issue-19 branch August 29, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Dockerize app
2 participants