PR fixes

leingenm · Aug 31, 2024 · 24398a1 · 24398a1
1 parent 3bc8989
commit 24398a1
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 12 deletions.
diff --git a/src/main/java/com/ypm/controller/LibraryImportController.java b/src/main/java/com/ypm/controller/LibraryImportController.java
@@ -17,18 +17,14 @@ public class LibraryImportController {
 
     private final ImportService importService;
 
-    @PostMapping("/watchLater")
-    public ResponseEntity<String> importWatchLaterLibrary(@RequestParam("file") MultipartFile file) {
+    @PostMapping("/watch-later")
+    public ResponseEntity<String> importWatchLaterLibrary(@RequestParam("file") MultipartFile file) throws IOException {
         if (file.isEmpty()) {
             return ResponseEntity.badRequest().build();
         }
 
         List<VideoImport> savedVideos;
-        try {
-            savedVideos = importService.importCsv(file);
-        } catch (IOException e) {
-            throw new RuntimeException(e); // TODO: Update exception handling
-        }
+        savedVideos = importService.importCsv(file);
 
         var responseBody = String.format("Saved %s videos", savedVideos.size());
         return ResponseEntity.ok().body(responseBody);

diff --git a/src/main/java/com/ypm/controller/VideoController.java b/src/main/java/com/ypm/controller/VideoController.java
@@ -20,7 +20,7 @@ public class VideoController {
     private final VideoService videosService;
     private final TokenService tokenService;
 
-    @PostMapping("/loadData")
+    @PostMapping("/load")
     public ResponseEntity<List<VideoDto>> getVideoData(@RequestBody List<String> videoIds) throws IOException {
         var videoData = videosService.getVideoData(videoIds);
 

diff --git a/src/main/java/com/ypm/persistence/entity/VideoImport.java b/src/main/java/com/ypm/persistence/entity/VideoImport.java
@@ -21,6 +21,6 @@ public class VideoImport {
 
     public VideoImport(String videoId, String videoTimeStamp) {
         this.videoId = videoId;
-        this.dateAdded = OffsetDateTime.parse(videoTimeStamp); // TODO: Is it okay solution?
+        this.dateAdded = OffsetDateTime.parse(videoTimeStamp);
     }
 }
diff --git a/src/main/java/com/ypm/service/youtube/ImportService.java b/src/main/java/com/ypm/service/youtube/ImportService.java
@@ -23,7 +23,6 @@ public class ImportService {
     public List<VideoImport> importCsv(MultipartFile file) throws IOException {
         final List<VideoImport> videos = new ArrayList<>();
 
-        // Parse CSV
         try (var reader = new BufferedReader(new InputStreamReader(file.getInputStream()))) {
             String line;
             var header = true;
@@ -42,7 +41,6 @@ public List<VideoImport> importCsv(MultipartFile file) throws IOException {
             }
         }
 
-        // Save into DB
         return videoRepository.saveAll(videos);
     }
 }
diff --git a/src/main/java/com/ypm/service/youtube/VideoServiceImp.java b/src/main/java/com/ypm/service/youtube/VideoServiceImp.java
@@ -75,7 +75,7 @@ public void deleteVideo(String accessToken, String videoId) throws IOException {
     public List<VideoDto> getVideoData(List<String> videoIds) throws IOException {
         final int maxResults = 50;
 
-        // Remove duplicates from the incoming list with ids
+        // DEV-NOTE: Remove duplicates from the incoming list with ids
         videoIds = videoIds.stream().distinct().toList();
         var videoDtoList = new ArrayList<VideoDto>();