-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE UNTIL KDS v5.0.0-rc3 INSTALLED] Remove hard-coded vuetify color on hover using $darken_ utitlity #4688
[DO NOT MERGE UNTIL KDS v5.0.0-rc3 INSTALLED] Remove hard-coded vuetify color on hover using $darken_ utitlity #4688
Conversation
Thanks @shivam-daksh! I will invite my colleague @ozer550 to review. Even though we can complete the review, just leaving a note here that we will merge it after the newest KDS release containing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look correct to me! I have tested them out locally and the results are similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @shivam-daksh and @ozer550. All looks good to me too! We will merge as soon as this KDS release is in Studio (that should also resolve the tests failure).
Studio already has the KDS version with |
@MisRob Thank you for merging! It took some time, but the effort was worth it 😊. I’ve been exploring the codebase and have successfully resolved a few beginner-friendly issues. I’m keen to dive deeper into the development side of Learning Equality and would love to contribute more. Could you please guide me on how to align my efforts with GSoC and point me toward any relevant projects or features that need attention? |
Hi @shivam-daksh. If we decide to participate, we usually submit a GSoC application in January, and then it takes some time for GSoC organizers to decide. Last time, accepted organizations were announced later in February if I recall. Best to keep an eye on https://summerofcode.withgoogle.com/. If we end up participating, some of the most important factors are:
So I think you already do what you can at this point. |
Summary
This PR addresses the issue of replacing the Vuetify color with the Kolibri Design System's (KDS) darken utility. Specifically, it updates the background color for the button that uses the Vuetify
--v-error-darken1
color variable.Changes Made
var(--v-error-darken1)
with the corresponding$darken_
utility from the Kolibri Design System once it is provided.Testing
Additional Context
This change improves the alignment with the Kolibri Design System and helps maintain design consistency across the application.
Screenshots (if applicable)
Does this introduce any tech-debt items?
Reviewer guidance
How can a reviewer test these changes?
Are there any risky areas that deserve extra testing?
References
#4634
Comments
Contributor's Checklist
PR process:
CHANGELOG
label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocs
label has been added if this introduces a change that needs to be updated in the user docs?requirements.txt
files also included in this PRStudio-specifc:
notranslate
class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages
,components
, andlayouts
directories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarn
andpip
)