Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Change|Reset)Password components apply length validation #4668

Conversation

nucleogenesis
Copy link
Member

Summary

Description of the change(s) you made

  • Copies the string definitions for the password length validation to other places where passwords are updated (Reset password, Change password from user account page)
  • Copies the validator functions over to the same components
  • Ensures length > 8
  • Adds a bit of height to the container of the KModal for the "Change password" because it would show a scroll bar whenever the errors were visible

Manual verification steps performed (Also Reviewer Guidance)

  1. Create an account
  2. Change your password from your account page
  3. Log out
  4. Click "Reset password" on the login page
  5. If you're running this locally, look at your server logs for the URL to reset your password otherwise check your email
  6. Click the reset password link
  • In all cases, if you put a password < 8 characters in length, you should see the appropriate error message.
  • You should also be able to actually update / reset your password 😄

Does this introduce any tech-debt items?

I do hate the hard-coded style there... and I feel like we've somehow fixed this another better way... but I could not think of it.

Is this something that is no longer a problem in upcoming KDS versions?

References

Fixes: #4646

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good to me and manual QA checks out in both places

@marcellamaki marcellamaki merged commit bb7a8a8 into learningequality:unstable Aug 27, 2024
13 checks passed
@marcellamaki marcellamaki mentioned this pull request Aug 27, 2024
@radinamatic
Copy link
Member

Manual QA on the unstable branch confirms the fix.

@akolson akolson mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unstable - Password reset - Password should be at least 8 characters long
4 participants