-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Welcome Embeddings 🚀 #4322
Welcome Embeddings 🚀 #4322
Conversation
contentcuration/contentcuration/migrations/0147_create_embeddings_table.py
Outdated
Show resolved
Hide resolved
@bjester github actions is failing because it uses the original postgres:12 image, we'll need to refactor our actions to support our docker compose. Meanwhile, I've verified locally, the related tests to this PR are passing. |
Just noting that this is blocked until we can get the GH Actions sorted and the extension enabled on the unstable server database |
#4341 is tracking the GH Actions update |
@vkWeb the GH Action is now using pg-vector. Although, do the tests pass on your machine? I ran them on mine and it complained about a missing storage bucket, but its directly connected to your tests:
|
@bjester the tests are passing on my system pretty well. Let's wait for the ci tests results. If CI fails then I will look deeper. |
@bjester yes you were right, tests are failing on CI and are failing on my system too. Running just tests related to embedding works but running all the tests together is failing. I'm looking into this. |
@bjester so this was an issue with the bucket getting deleted (fixed in the most recent commit 🎉), let me explain in detail -- When only But when all the tests are run together, any test that's run before This brings to me that we can improve on our developer experience with how our test classes are laid out. It was really a non-intuitive experience. |
@bjester this is ready to merge 🎉 |
Code looks good. Last blocker is to get the extension enabled in the |
3861ca1
into
learningequality:search-recommendations
Summary
Description of the change(s) you made
Added an Embeddings model that allows caching of generated embeddings and enables calculation of closest embeddings for recommending contentnodes.
Manual verification steps performed
make run-services
in one terminal.pytest -s -k EmbeddingsTestCase
.Reviewer guidance
How can a reviewer test these changes?
Performing manual verification steps should be enough.
References
Closes #4290.
Contributor's Checklist
PR process:
CHANGELOG
label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocs
label has been added if this introduces a change that needs to be updated in the user docs?requirements.txt
files also included in this PRStudio-specifc:
notranslate
class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages
,components
, andlayouts
directories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarn
andpip
)