Implements Automation Manager Class #4306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akolson
reviewed
Oct 4, 2023
|
|
||
| class AutomationManager: | ||
| def __init__(self): | ||
| self.reccomendations_backend_instance = Recommendations() |
There was a problem hiding this comment.
I think this should be the RecommendationsBackendFactory
akolson
reviewed
Oct 10, 2023
| class AutomationManager: | ||
| def __init__(self): | ||
| self.reccomendations_backend_factory = RecommendationsBackendFactory() | ||
| self.reccomendations_backend_instance = self.reccomendations_backend_factory.create_backend() |
There was a problem hiding this comment.
perhaps recommendations_backend_instance and recommendations_backend_factory instead?
Might be a good idea to keep the words consistent. These type are normally a source of bugs 🙂
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the automation_manager class responsible for interacting with the backends and adapters. Also adds some basic tests related to the implemented code.
References
closes #4295
Comments
Currently, most of the core functions are mocked to return truthy values. All tests and core implementation needs to be changed when backend is implemented completely.
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)