Moved login/logout logic into the useUser composable and updated references #12915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put commit ref in external file. Update all static files for new build.
…content_id. Use node_id when available. Query for most recent session log to give parallel results for summary logs.
Take advantage of reduced build time to add to PR build.
…uthmessage w/ urls
…g even if an error occurs mid-navigation (for example, like in QuizSummary's beforeRouteEnter)
…lity_continue Conditionalize hideContinue on whether we are displaying an error or not
…angelog-0.17.4 Update changelog for 0.17.4
# Conflicts: # kolibri/__init__.py
…osition API useUser
Build Artifacts
|
…dabot/npm_and_yarn/katex-0.16.18 Bump katex from 0.16.17 to 0.16.18
Auto update h5p
…osition API useUser
github-actions
bot
added
DEV: dev-ops
|
When I did a rebase locally on develop here, it threw up some weird conflicts, but resolving them during the rebase did reduce it down to only about 10 commits, so I think this can be cleaned up! Let me know if it would be helpful for me to force push updates for this. |
Thank you for your help! If you think force pushing the updates would clean up the commit history and make it easier to manage, I would appreciate it. Please go ahead and do so if it's not too much trouble. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Login/logout and session logic is moved into
useUsercomposable fromaction.js. Refactored vuex state into module level state. References toCORE_SET_SESSIONis updated to use the setSession method from useUser composable.References
fixes #12204
Reviewer guidance
after updating references to
CORE_SET_SESSIONinheartbeat.spec.jsfile, some tests still failed. I am unable to figure out why these tests are failing. I updated the mock file and implementated it as written in documentation.