Ensure facility id is properly sent to public signup viewset. #11846
Conversation
github-actions
bot
added
DEV: backend
|
I believe this nuance was my reasoning for adding a constant for it, which could be used here? kolibri/kolibri/core/auth/backends.py Line 9 in 5bd813d |
| @@ -51,7 +51,9 @@ def createuseronremote(self, request): | |||
| url = "{}{}".format(baseurl, api_url) | |||
|
|
|||
| payload = { | |||
| "facility_id": facility_id, | |||
| # N.B. facility is keyed by facility not facility_id on the signup | |||
There was a problem hiding this comment.
What's N.B. mean here?
Why not update the serializer field to be facility_id instead?
There was a problem hiding this comment.
Too many other places to have to change on the frontend I suspect?
In any case, change looks good to me
There was a problem hiding this comment.
Nota Bene - note well.
Changing the public serializer would involve changing the serializer for all signups, so would be a fairly significant change. If I was going to make a more dramatic change here, I would propagate this back through this API endpoint (to be facility all the way) but this seemed like the least dramatic fix this close to release.
Build Artifacts
|
|
Yes @bjester that does seem appropriate! I'll update. |
Summary
facility_idinstead of the expectedfacilityReferences
Fixes #11832
Reviewer guidance
Use the database from the linked issue for a server device, and then attempt to create a new user account for
jerrymusername on the second facility (imported from Win11).Testing checklist
PR process
Reviewer checklist
yarnandpip)