Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail when a lesson or exam is assigned through multiple ways. #11845

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Feb 7, 2024

Summary

  • Fixes bug where an exam or lesson assigned via a class and a group (for example) would cause an error during the post sync hooks because of multiple objects being returned

References

Unreported bug, but could have been the cause of syncing errors.

Reviewer guidance

This just takes the first assignment, any issues with this?


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Feb 7, 2024
@rtibbles rtibbles requested review from jamalex and bjester February 7, 2024 22:41
@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... SIZE: very small labels Feb 7, 2024
@rtibbles
Copy link
Member Author

rtibbles commented Feb 8, 2024

Sorry, @rtibbles, we decided to go in a different direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem... SIZE: very small TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant