Make site title configurable via the theme hook. #11433
Conversation
rtibbles
added this to the Kolibri 0.16 Release: Existing Projects/General/Maintenance milestone
github-actions
bot
added
DEV: backend
Build Artifacts
|
| Return the text of the site title, if provided by the theme. If not, the | ||
| default will be returned. | ||
| """ | ||
| return ThemeHook.get_theme().get("siteTitle", _("Kolibri")) |
There was a problem hiding this comment.
My translation knowledge is shaky at best, but does this support translation of the title in the theme?
There was a problem hiding this comment.
As far as I understand things, yes, the theme should support translation. The theme is just a Django plugin with a hook which returns a dict of values. It should be able to call _() on the value it returns for siteTitle.
(That would mean we need to set up gettext support for kolibri-endless-key-theme, but that’s fairly straightforward.)
| Return the text of the site title, if provided by the theme. If not, the | ||
| default will be returned. | ||
| """ | ||
| return ThemeHook.get_theme().get("siteTitle", _("Kolibri")) |
There was a problem hiding this comment.
As far as I understand things, yes, the theme should support translation. The theme is just a Django plugin with a hook which returns a dict of values. It should be able to call _() on the value it returns for siteTitle.
(That would mean we need to set up gettext support for kolibri-endless-key-theme, but that’s fairly straightforward.)
There was a problem hiding this comment.
@rtibbles and I discussed the pros and cons of various approaches, and this seems like the option to go with (at least for now!)
Co-authored-by: Philip Withnall <[email protected]>
Summary
siteTitleto allow it be configured_("Kolibri")Kolibriin the base.html, unsupported_browser.html and pwa manifest.json to use this template tagReferences
Fixes #10958
Reviewer guidance
This only affects the backend usages of the site title, and only standalone usages of
Kolibri- a follow up issue will be filed to complete this work, but it would require string changes in order to accommodate fully.To test this, probably the easiest thing is to go to http://127.0.0.1:8000/ar/unsupported/ and ensure that the page title still displays as
كوليبريTesting checklist
PR process
Reviewer checklist
yarnandpip)