Fix styles

learningequality · Dec 19, 2024 · ef6d377 · ef6d377
1 parent 0e98688
commit ef6d377
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 12 deletions.
diff --git a/...ts/src/views/common/assignments/SidePanelRecipientsSelector/LearnersSelectorSidePanel.vue b/...ts/src/views/common/assignments/SidePanelRecipientsSelector/LearnersSelectorSidePanel.vue
@@ -12,10 +12,11 @@
         {{ $tr('selectGroupsAndIndividualLearnersTitle') }}
       </h1>
     </template>
-    <div style="padding-top: 30px">
-      <!-- TODO: remove this div once SidePanelModal is fixed-->
+    <template #default>
       <section>
-        <h2>{{ coachString('groupsLabel') }}</h2>
+        <h2 class="mt-0">
+          {{ coachString('groupsLabel') }}
+        </h2>
         <KCheckbox
           v-for="group in groups"
           :key="group.id"
@@ -55,7 +56,7 @@
           @update:selectedLearnerIds="updateAdHocLearners"
         />
       </section>
-    </div>
+    </template>
     <template #bottomNavigation>
       <div class="bottom-nav-container">
         <KButton
@@ -189,11 +190,14 @@
 
 <style lang="scss" scoped>
 
+  .mt-0 {
+    margin-top: 0;
+  }
+
   .bottom-nav-container {
     display: flex;
     justify-content: flex-end;
     width: 100%;
-    margin-bottom: 16px;
   }
 
   .side-panel-title {

diff --git a/packages/kolibri-common/components/SidePanelModal/index.vue b/packages/kolibri-common/components/SidePanelModal/index.vue
@@ -88,8 +88,6 @@
         /* Will be calculated in mounted() as it will get the height of the fixedHeader then */
         // @type {RefImpl<number>}
         windowBreakpoint,
-        fixedHeaderHeight: 0,
-        fixedBottombarHeight: 0,
         lastFocus: null,
       };
     },
@@ -181,11 +179,6 @@
     mounted() {
       const htmlTag = window.document.getElementsByTagName('html')[0];
       htmlTag.style['overflow-y'] = 'hidden';
-      // Gets the height of the fixed header - adds 40 to account for padding + 24 for closeButton
-      this.fixedHeaderHeight = this.$refs.fixedHeader.clientHeight;
-      if (this.$refs.fixedBottombar) {
-        this.fixedBottombarHeight = this.$refs.fixedBottombar.clientHeight;
-      }
       this.$nextTick(() => {
         this.$emit('shouldFocusFirstEl');
       });