Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the strings in the Windows installer po file #165

Conversation

mrpau-richard
Copy link
Contributor

I updated the strings in the installer po file.

cc @radinamatic

@radinamatic
Copy link
Member

From #164 (comment)

include only the strings that appear in 5-6 steps visible in the default installation.

...
Agreed that if possible, we should identify the strings we actually need and systematically get just those translated.

@mrpau-dev @mrpau-richard Would it be possible to achieve the above in the scope of this PR, or you prefer this to be merged first?

The goal is to filter the strings so the PO file contains only our custom ones, plus those that appear in the installer default 5-6 windows/steps.

@cpauya
Copy link
Contributor

cpauya commented Apr 29, 2020

Agree @radinamatic - We will modify the PO file here to contain only our customized strings (including those in the installer UI wizard).

@benjaoming
Copy link
Contributor

Agreed that if possible, we should identify the strings we actually need and systematically get just those translated.

Suggestion: If we use a blacklist (list of all the strings to ignore), we won't have to remember to update a separate whitelist (a whitelist would also mean that "extracting" something from the .isl becomes largely meaningless).

@mrpau-richard
Copy link
Contributor Author

@radinamatic I modify the po file to just translate those strings that we customised in the isl file. I think this PR is ready to merge and upload the installer po at Crowdin

@radinamatic
Copy link
Member

our custom ones, plus those that appear in the installer default 5-6 windows/steps.

@mrpau-richard You've been a bit overzealous in slashing out those strings, and left out everything BUT those that we customized 😂

Remember that ALL the strings that appear in Setup Wizard installation steps need to be translated in 22 languages we currently support in Kolibri (plus Chinese), and not all of them appear to be available in the InnoSetup according to its own language selector:

Selection_465

Changes to be implemented include, for example: eliminate Greek (that we do not support at the moment), change PT-PT for PT-BR, and include all the rest of the supported ones indicated in language_info.json.

I'm including a version of PO file with what I believe covers all the strings that we should aim to make available for translation: kolibri-installer.po.zip

cc @cpauya

@benjaoming
Copy link
Contributor

As suggested in the meeting:

Customized strings in the installer are written to src/installer-and-application-po-files/kolibri-installer.po (what this PR does).

The remaining standard InnoSetup strings could be extracted to a separate file so they can be translated only for the languages necessary? src/installer-and-application-po-files/innosetup.po ?

@mrpau-richard
Copy link
Contributor Author

@radinamatic I created another po file for the InnoSetup strings as @benjaoming suggested comment above.

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this looks good to me, @benjaoming would you check it out too? Thanks!

Copy link
Contributor

@benjaoming benjaoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are changes here indicating that .po files were created through a manual process. I guess we will need a manual process as well to ensure that all translation strings were captured, since there are several strings left out now (for instance "Arial"). I will post a follow-up issue.

@benjaoming benjaoming merged commit d2e161a into learningequality:develop May 11, 2020
@benjaoming
Copy link
Contributor

@radinamatic does this fix #150 ?

@benjaoming
Copy link
Contributor

benjaoming commented May 11, 2020

Does this fix #148 once the .po files have been pushed?

@radinamatic
Copy link
Member

does this fix #150 ?

Hopefully it will, once the translations are in 😉

Does this fix #148 once the .po files have been pushed?

To my understanding it will.
Switching the conversation there, since this is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants