-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the strings in the Windows installer po file #165
Update the strings in the Windows installer po file #165
Conversation
From #164 (comment)
@mrpau-dev @mrpau-richard Would it be possible to achieve the above in the scope of this PR, or you prefer this to be merged first? The goal is to filter the strings so the PO file contains only our custom ones, plus those that appear in the installer default 5-6 windows/steps. |
Agree @radinamatic - We will modify the PO file here to contain only our customized strings (including those in the installer UI wizard). |
Suggestion: If we use a blacklist (list of all the strings to ignore), we won't have to remember to update a separate whitelist (a whitelist would also mean that "extracting" something from the .isl becomes largely meaningless). |
@radinamatic I modify the po file to just translate those strings that we customised in the isl file. I think this PR is ready to merge and upload the installer po at Crowdin |
@mrpau-richard You've been a bit overzealous in slashing out those strings, and left out everything BUT those that we customized 😂 Remember that ALL the strings that appear in Setup Wizard installation steps need to be translated in 22 languages we currently support in Kolibri (plus Chinese), and not all of them appear to be available in the InnoSetup according to its own language selector: Changes to be implemented include, for example: eliminate Greek (that we do not support at the moment), change PT-PT for PT-BR, and include all the rest of the supported ones indicated in I'm including a version of PO file with what I believe covers all the strings that we should aim to make available for translation: kolibri-installer.po.zip cc @cpauya |
As suggested in the meeting: Customized strings in the installer are written to The remaining standard InnoSetup strings could be extracted to a separate file so they can be translated only for the languages necessary? |
@radinamatic I created another po file for the InnoSetup strings as @benjaoming suggested comment above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, this looks good to me, @benjaoming would you check it out too? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are changes here indicating that .po files were created through a manual process. I guess we will need a manual process as well to ensure that all translation strings were captured, since there are several strings left out now (for instance "Arial"). I will post a follow-up issue.
@radinamatic does this fix #150 ? |
Does this fix #148 once the .po files have been pushed? |
I updated the strings in the installer po file.
cc @radinamatic