Display the kolibri link address to the system tray message - alternate branch

[cpauya]

Supersedes #106

Addresses this issue: #104

Testing PR: Grab the unsigned Windows installer here learningequality/kolibri#5743

Note: WIP, needs to create a testing PR for this, please don't merge yet.

[mrpau-richard]

I tested this on Windows 7 and it's working as expected.

[benjaoming]

There are 3 binary files in this PR, are they build artifacts?

[mrpau-julius]

@benjaoming The Resource.rc and Ressource.h are a text file, not a binary. I don't know why GitHub treated that a binary. We discussed the kolibri.exe to create a separate issue and find ways on how to solve it. @cpauya agree that all the files on the repository must be a text or image, not binary files.

[cpauya]

Good question @benjaoming 😸 and to answer it: No they are not build artifacts. 😿

It's indeed weird Github is treating the .rc and .h files as binaries. Their contents are in plain text as you can see here:

• /windows/gui-source/Kolibri/Resource.rc
• /windows/gui-source/Kolibri/resource.h

However, the Kolibri.exe being in the repo is questionable.

As much as possible, our repo should contain only sources, images (which are binary files too), maybe reference libraries (.dll, .lib, etc) and NO binary executables as much as possible. This is a remnant of the way things worked with KA-Lite for Windows before: https://github.com/learningequality/ka-lite-installers/tree/master/windows/gui-packed

So yes, we must create another issue for removing Kolibri.exe from the source repo @mrpau-julius and have that auto-generated during build.

[cpauya]

Ha! The binary treatment apparently has possibly lots of reasons why as per this StackOverflow post: 😸

• file encoding in UTF-8 or UTF-16
• long lines of strings in text file
• Unicode characters inside the text file
• etc

[cpauya]

This 120 character-limiting index seems unusual. Although I think it's trivial for now but let's take note in case the notification will take longer than 120 characters.

[benjaoming]

@cpauya thanks for explaining and looking into why Github gives this wrong classification of the two files - one more question: how is kolibri.exe built if it's not a build artifact?

[cpauya]

The executable `Kolibri.exe` is built in our local machines during devt with the Visual Studio (VS) IDE. On the side, I'm hoping BuildKite has support for building VS projects (via command-line) so we can remove this from the repo and auto-build it along with the installers. Initial search shows this for the supported pipelines in BuildKite: https://github.com/buildkite/example-pipelines - sadly it doesn’t include Visual Studio. Will keep looking. 😅

[cpauya]

Merging this now.

Further testing may be done in this Testing PR for milestone 1.3.1 at learningequality/kolibri#5749

[benjaoming]

@cpauya Is it not possible to build this kolibri.exe in a Wine environment?

[indirectlylit]

@benjaoming we opened up a new issue for kolibri.exe since it was unrelated to this PR: #112