Merge release-v4 and bump kds version

learningequality · Sep 17, 2024 · d72ff52 · d72ff52
2 parents 34b8762 + fc6634a
commit d72ff52
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -512,6 +512,17 @@ Changelog is rather internal in nature. See release notes for the public overvie
 
 <!-- [DO NOT REMOVE-USED BY GH ACTION] PASTE CHANGELOG -->
 
+- [#784]
+  - **Description:** Adds `labelDir` prop to control rtl direction of label.
+  - **Products impact:** new API.
+  - **Addresses:** https://github.com/learningequality/studio/issues/4728.
+  - **Components:** KCheckbox, KRadioButton.
+  - **Breaking:** no
+  - **Impacts a11y:** no.
+  - **Guidance:** -.
+
+[#784]: https://github.com/learningequality/kolibri-design-system/pull/784
+
 - [#767]
   - **Description:** Bump KDS version to 4.5.0.
   - **Products impact:** -.

diff --git a/lib/KCheckbox.vue b/lib/KCheckbox.vue
@@ -45,7 +45,7 @@
       </div>
 
       <label
-        dir="auto"
+        :dir="labelDir"
         class="k-checkbox-label"
         :for="id"
         :class="{ 'visuallyhidden': !showLabel }"
@@ -84,6 +84,14 @@
         type: String,
         default: null,
       },
+      /**
+       * RTL dir of the text label
+       * Options: 'auto', 'ltr', 'rtl', null.
+       */
+      labelDir: {
+        type: String,
+        default: 'auto',
+      },
       /**
        * Whether or not to show the label
        */

diff --git a/lib/KRadioButton.vue b/lib/KRadioButton.vue
@@ -37,7 +37,7 @@
       </div>
 
       <label
-        dir="auto"
+        :dir="labelDir"
         class="k-radio-button-label"
         :for="id"
         :class="{ 'visuallyhidden': !showLabel }"
@@ -99,6 +99,14 @@
         type: Boolean,
         default: true,
       },
+      /**
+       * RTL dir of the text label
+       * Options: 'auto', 'ltr', 'rtl', null.
+       */
+      labelDir: {
+        type: String,
+        default: 'auto',
+      },
       /**
        * Component `data` with which to associate this radio button and its siblings
        */

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "kolibri-design-system",
-  "version": "5.0.0-rc5",
+  "version": "5.0.0-rc6",
   "private": false,
   "description": "The Kolibri Design System defines common design patterns and code for use in Kolibri applications",
   "repository": {