New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate/storybook v5 #16

Open

rudolphfunk wants to merge 3 commits into leandrooriente:master from rudolphfunk:migrate/storybook-v5

rudolphfunk commented Mar 13, 2019

PR for Storybook V5 migration, which required:

Update project dependencies to latest versions
migration of Storybook config according to docs
changed of webpack.config to "Extend mode"
Removed options addon, which is deprecated
declared custom disabled prop according to docs
changed type from React.ReactNode to JSX.Element to make Unit test pass

bijenkorf-james-wakefield added 3 commits

March 13, 2019 14:41


          Migrated dependencies and configuration to v5 and confirmed working. …

f2d9c9d

…Fixed broken Unit test


          Fixed props for styled component so UT passes

20245db


          Adding type for filename arg in foreach

7ff04a7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet