Rewrite with tool library #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added config for Babel in an attempt to not have it compile the node_modules folder. Added the packages that are dependencies for the tools. The submission model change is unfortunate. This was introduced in the rewrite with the tools which makes the rewritten services somewhat incompatible with the original services.
When removing unused packages, the ForkingStore jumped out as only being used sparingly and something that does not provide much documentation. So this was removed in favour of some basic transformations with N3 stores. I'm sorry, but if there is no documentation on a library, I'm not using it, and I will convert code to using libraries that are properly documented and well tested. I don't want to debug something like that otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites a lot of code using the automatic-submission-flow-tools library and also using more of the RDF.JS libraries to simplify.
These changes are mostly the same as the other PR's. The most notable change is the removal of the ForkingStore. That library does not have any documentation and its functionality can (for this service) be replaced by rather simple transformations with a regular RDF store.