Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added example to create partials using gulp-wrap #11

Closed
wants to merge 4 commits into from

Conversation

kahwee
Copy link

@kahwee kahwee commented Feb 18, 2014

Referencing #10, before I go on removing the wrapped parameter, I wrote the documentation for how to possibly use gulp-wrap to achieve partials support.

What do you think @lazd?

@@ -42,6 +42,29 @@ gulp.task('templates', function(){
});
```

## Compiling to a partial for the browser

[gulp-wrap] can be used to compile templates for the browser. Just pipe the output of gulp-handlebars to gulp-declare:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Partials aren't for just the browser only, they can be used in any Handlebars environment.
  2. The convention in this README is to wrap module names in backticks
`[gulp-wrap]` can be used to compile partials. Just pipe the output of `gulp-handlebars` to `gulp-declare`:

@lazd
Copy link
Owner

lazd commented Feb 18, 2014

Definitely squash so your PR doesn't include doesn't include the reverted changes (97b492f and e97ceec). If you're new to squashing, you can just do:

git reset 97b492fddb2115d489304137187230490c0f8bed~1
git add .
git commit -m "Add documentation on compiling partial for the browser using gulp-wrap."
git push origin without-wrap --force

@kahwee
Copy link
Author

kahwee commented Feb 19, 2014

Thanks @lazd, I've made another pull request address them.

@lazd
Copy link
Owner

lazd commented Feb 19, 2014

Superseded by #12

@lazd lazd closed this Feb 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants