Merge pull request #754 from jerensl/learning-card

refactor: make the link tag optional on learning card
layer5io · Oct 17, 2024 · 21bed8a · 21bed8a
2 parents e427107 + 20983da
commit 21bed8a
Showing 1 changed file with 11 additions and 3 deletions.
diff --git a/src/custom/LearningCard/LearningCard.tsx b/src/custom/LearningCard/LearningCard.tsx
@@ -25,11 +25,19 @@ interface Tutorial {
 
 interface Props {
   tutorial: Tutorial;
-  path: string;
+  path?: string;
   courseCount: number;
   courseType: string;
 }
 
+const OptionalLink: React.FC<React.PropsWithChildren<{ path?: string }>> = ({ path, children }) => {
+  if (!path) {
+    return <>{children}</>;
+  }
+
+  return <CardLink href={path}>{children}</CardLink>;
+};
+
 const LearningCard: React.FC<Props> = ({ tutorial, path, courseCount, courseType }) => {
   return (
     <CardWrapper>
@@ -57,7 +65,7 @@ const LearningCard: React.FC<Props> = ({ tutorial, path, courseCount, courseType
           </CardParent>
         </Card2>
       ) : (
-        <CardLink href={path}>
+        <OptionalLink path={path}>
           <CardActive>
             <CardParent style={{ borderTop: `5px solid ${tutorial.frontmatter.themeColor}` }}>
               <div>
@@ -88,7 +96,7 @@ const LearningCard: React.FC<Props> = ({ tutorial, path, courseCount, courseType
               </div>
             </CardParent>
           </CardActive>
-        </CardLink>
+        </OptionalLink>
       )}
     </CardWrapper>
   );