-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase size of Kanvas icon for better visibility #6070
base: master
Are you sure you want to change the base?
Increase size of Kanvas icon for better visibility #6070
Conversation
Signed-off-by: Tharanishwaran <[email protected]>
🚀 Preview for commit be1a4d4 at: https://6730e2adaeb49ae29e91292c--layer5.netlify.app |
@vishalvivekm, the icons appear larger to me on the https://6730e2adaeb49ae29e91292c--layer5.netlify.app/cloud-native-management/kanvas |
@vishalvivekm, are there any changes needed in this PR? |
@Tharanishwaran please check the logo in different screen width, if you would |
Okay @vishalvivekm , I will test it on different screens and commit the changes afterward. |
@vishalvivekm , I made the changes and tested the logo on all screen sizes. Here’s a screenshot of how the logo looks on the last screen size. |
src/sections/Kanvas/kanvas-icon.svg
Outdated
@@ -11,10 +11,12 @@ | |||
} | |||
</style> | |||
</defs> | |||
<g transform="scale(1)"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of using the transform property in the SVG, which can cause sizing issues when the logo is used in different contexts, could you explore alternative ways to increase the size of the Kanvas logo? This will help ensure it maintains quality and consistent dimensions across various placements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NishantSinghhhhh Thanks for the feedback.
@Tharanishwaran Thank you for your contribution! Please add it as an agenda item to the meeting minutes. |
Signed-off-by: Tharanishwaran <[email protected]>
…/layer5 into Increase-size-Kanvas-icon
🚀 Preview for commit 397c354 at: https://6733895af175d70879002fc7--layer5.netlify.app |
Description
This PR fixes #
Notes for Reviewers
This PR increases the size of Kanvas icon on the layer5.io/kanvas page to enhance visual clarity.
Before :
After :
Signed commits