Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TextField component to the sistent components page #5948 #6008

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Add TextField component to the sistent components page #5948 #6008

merged 3 commits into from
Oct 24, 2024

Conversation

nooras
Copy link
Contributor

@nooras nooras commented Oct 19, 2024

Description
Add TextField component to the sistent components page

This PR fixes #
#5948

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Screenshot:
screencapture-localhost-8000-projects-sistent-components-2024-10-19-20_19_31

@github-actions github-actions bot added the area/projects An issue relating to Layer5 initiatives (projects) label Oct 19, 2024
@l5io
Copy link
Contributor

l5io commented Oct 19, 2024

🚀 Preview for commit bfd7e4c at: https://6713d1eb18a026d785930e4c--layer5.netlify.app

@nooras nooras mentioned this pull request Oct 19, 2024
Closed
@l5io
Copy link
Contributor

l5io commented Oct 19, 2024

🚀 Preview for commit 76aae33 at: https://6713d883ee5caad9b39ed31e--layer5.netlify.app

@vishalvivekm
Copy link
Member

@nooras
Thank you for your contribution!
Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT).

Please add it as an agenda item to the meeting minutes.

@vishalvivekm
Copy link
Member

@nooras Thank you for your contribution! Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT).

Please add it as an agenda item to the meeting minutes.

adding

@vishalvivekm vishalvivekm mentioned this pull request Oct 21, 2024
Closed
sudhanshutech
sudhanshutech requested changes Oct 22, 2024
View reviewed changes
src/sections/Projects/Sistent/components/text-field/index.js Outdated
<SistentLayout title="TextField" >
<div className="content">
<a id="Identity">
<h2>TextField</h2>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text Field

src/sections/Projects/Sistent/components/text-field/code-block.js Outdated
@@ -0,0 +1,19 @@
import React, { useState } from "react";
import Code from "../../../../../components/CodeBlock";
export const CodeBlock = ({ name, code }) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nooras isn't code block component already there then why creating new?

sudhanshutech
sudhanshutech requested changes Oct 22, 2024
View reviewed changes
Copy link
Member

@sudhanshutech sudhanshutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add some space
image

@sudhanshutech
Copy link
Member

merge conflicts...

@nooras
Copy link
Contributor Author

nooras commented Oct 23, 2024 •
edited
Loading

@vishalvivekm @sudhanshutech @SAHU-01 @nebula-aac
Please review the PR. I have made changes as per request & removed conflicts.

@l5io
Copy link
Contributor

l5io commented Oct 23, 2024

🚀 Preview for commit d2c1f52 at: https://671939227bdcdc52dccce67e--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Oct 24, 2024

🚀 Preview for commit ff800ee at: https://6719f7a3f1138a8875d68370--layer5.netlify.app

@sudhanshutech sudhanshutech merged commit 7c713a8 into layer5io:master Oct 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudhanshutech sudhanshutech sudhanshutech approved these changes

@hargunkaur286 hargunkaur286 Awaiting requested review from hargunkaur286

@SAHU-01 SAHU-01 Awaiting requested review from SAHU-01

@nebula-aac nebula-aac Awaiting requested review from nebula-aac

Assignees
No one assigned
Labels
area/projects An issue relating to Layer5 initiatives (projects) project/sistent
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nooras @l5io @vishalvivekm @sudhanshutech