Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Mobile: Migrate global-style.js to TypeScript #10091

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Mar 8, 2024

Summary

This pull request migrates global-style.js to TypeScript. This migration was originally done as a part of the mobile plugins pull request (#9652).

Testing

The goal of this testing plan is to verify that the modified screens that are still .js files can open and be used.

  1. Open the app
  2. Navigate to settings
  3. Navigate to the Dropbox login page
  4. Navigate to the OneDrive login page
  5. Open a note in the editor
  6. Add text to the end of the note
  7. Open the link dialog
  8. Add a drawing
  9. Navigate to the "tags" dialog and open a note
  10. Show the sidemenu for that note
  11. Open the "sync status" screen from settings

This has been successfully tested on Android 13.

@laurent22 laurent22 merged commit d7401d7 into laurent22:dev Mar 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants