Codec refactorings #1241
Merged
Codec refactorings #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f there are Codec instances for the types, a registry and a mapping from schema tu parsed schema
|
@barambani / @amir please take a look |
|
@amir / @barambani please review |
barambani
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to address this followup, I am trying to decouple the presence of the schema registry libs in places where codecs are defined. This since most likely people are being bitten by the automatic codec derivation of avro4s and - given Tamer itself automatically derives Codec too(!) - end up with needing the whole dependency tree of tamer...
Basing this off #1101