Fix several minor issues on FileService #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejitak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following three minor fixes.
Use original_file_name for file model scheme
Use
original_file_nameinstread oforiginal_filenameto align with File Model scheme.Fix a parameter name for fileUploadService->delete
Use
keyinstread ofs3_key.s3_keyis not used in https://github.com/laravel-rocket/foundation/blob/master/src/Services/Production/FileUploadS3Service.php#L87Fix unlink argument
Originally, the code causes an error
unlink() expects parameter 1 to be a valid path.... To fix it, change the parameter to file path string.