Updating ids of discretized pipes and associated junctions in the transient version #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a linear approximation for pipe head loss. Replacing the problem ogf_compr_power_proxy by ogf_comp_power_and_pipe_proxy to help the simulator
Updating the ids of the newly introduced junctions and pipes due to pipe discretization in the transient version. This update ensures that the ids of the newly created junctions do not overlap with the original junctions
This reverts commit 4ca98ac.
|
Everything looks good. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits to ensure that the original junctions do not get overwritten by newly created junctions while discretizing pipes.