Skip to content

Commit

Permalink
Script updating archive at 2024-09-29T01:05:04Z. [ci skip]
Browse files Browse the repository at this point in the history
  • Loading branch information
ID Bot committed Sep 29, 2024
1 parent 6848e83 commit d19575c
Showing 1 changed file with 65 additions and 9 deletions.
74 changes: 65 additions & 9 deletions archive.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"magic": "E!vIA5L86J2I",
"timestamp": "2024-09-26T00:59:32.964861+00:00",
"timestamp": "2024-09-29T01:04:56.821647+00:00",
"repo": "lamps-wg/csr-attestation",
"labels": [
{
Expand Down Expand Up @@ -1813,9 +1813,17 @@
"labels": [],
"body": "Feedback from Carl:\r\n\r\n> Section B.1\r\n> This should probably be presented as a standalone ASN.1 module that adds this definition instead of as a snip from an ASN.1 module.\r\n\r\nI will discuss with @nedmsmith .",
"createdAt": "2024-07-01T13:03:45Z",
"updatedAt": "2024-07-01T13:03:45Z",
"updatedAt": "2024-09-26T18:20:23Z",
"closedAt": null,
"comments": []
"comments": [
{
"author": "nedmsmith",
"authorAssociation": "COLLABORATOR",
"body": "Fixed in PR #160",
"createdAt": "2024-09-26T18:20:22Z",
"updatedAt": "2024-09-26T18:20:22Z"
}
]
},
{
"number": 145,
Expand Down Expand Up @@ -1924,7 +1932,7 @@
"labels": [],
"body": "@henkbirkholz asked me to look at B.1 and B.2.\r\n\r\nTwo observations:\r\n\r\n* The title is the same and a good percentage of the prose portion is repeated. It is not clear why both sections are needed. (My guess is you wanted to have CMW and TCBInfo examples one alongside the other, but for some reason, you ended in this garbled situation.)\r\n* The example in B.2 is not a CMW, it's a DICE TCBInfo. To be a CMW it should use OID [id-pe-cmw](https://www.iana.org/assignments/smi-numbers/smi-numbers.xhtml#smi-numbers-1.3.6.1.5.5.7.1), and the encoding defined in [Section 5 of CMW](https://www.ietf.org/archive/id/draft-ietf-rats-msg-wrap-08.html#section-5-8).\r\n\r\nIn conclusion:\r\n1. The title of B.2 should be \"TCG DiceTCBInfo in CSR\", and\r\n2. B.1 still needs some tender love and care.\r\n \r\nThis may be related to #144 ",
"createdAt": "2024-09-10T07:19:23Z",
"updatedAt": "2024-09-24T18:59:49Z",
"updatedAt": "2024-09-26T17:57:54Z",
"closedAt": null,
"comments": [
{
Expand All @@ -1947,6 +1955,13 @@
"body": "Here's proposed ASN.1 for Section B.1\r\nI noted there was no name given to the DEFINITIONS section that defined EvidenceStatementSet. Was there a reason?\r\nI found it helpful to give it a name so I can write the IMPORTS section, namely: EvidenceStatementSet FROM CsrAttestation \r\n\r\nShould I give it a name in a PR to add the other ASN.1?\r\n\r\nNote also the TcgDice block defines the other DICE OIDs that show up in the OID registry in the IANA section.\r\n\r\nI also noticed the B.2 section is mislabeled as it is showing a DiceTcbInfo example. The updated ASN.1 shows construction of an EvidenceStatementSet containing both Dice CMW and Dice TcbInfo structures.\r\n\r\n```\r\nCsrAttestationDiceExample DEFINITIONS IMPLICIT TAGS ::= BEGIN\r\n\r\nIMPORTS \r\n\r\ntcg-dice-conceptual-message-wrapper FROM TcgDice\r\nDiceConceptualMessageWrapper FROM TcgDice\r\n\r\nEvidenceStatementSet FROM CsrAttestation \r\n;\r\n\r\ntcgDiceCmwEvidenceStatementES EVIDENCE-STATEMENT ::=\r\n { DiceConceptualMessageWrapper IDENTIFIED BY tcg-dice-conceptual-message-wrapper }\r\n\r\ntcgDiceTcbInfoEvidenceStatementES EVIDENCE-STATEMENT ::=\r\n { DiceTcbInfo IDENTIFIED BY tcg-dice-TcbInfo }\r\n-- where ConceptualMessageWrapper, tcg-dice-conceptual-message-wrapper, DiceTcbInfo, and tcg-dice-TcbInfo\r\n-- are defined in DICE-Attestation-Architecture-Version-1.1-Revision-17_1August2023.pdf\r\n\r\nEvidenceStatementSet EVIDENCE-STATEMENT ::= {\r\n tcgDiceEvidenceStatementES, \r\n tcgDiceTcbInfoEvidenceStatementES, \r\n ...\r\n}\r\nEND\r\n\r\nTcgDice DEFINITIONS IMPLICIT TAGS ::= BEGIN\r\n\r\nEXPORTS ALL;\r\n\r\ntcg OBJECT IDENTIFIER ::= { 2 23 133 }\r\ntcg-dice OBJECT IDENTIFIER ::= { tcg platformClass(5) dice(4) }\r\ntcg-dice-TcbInfo OBJECT IDENTIFIER ::= { tcg-dice tcbinfo(1) }\r\ntcg-dice-MultiTcbInfo OBJECT IDENTIFIER ::= {tcg-dice multitcbinfo(5) }\r\ntcg-dice-UCCS-evidence OBJECT IDENTIFIER ::= {tcg-dice uccs-evidence(6) }\r\ntcg-dice-manifest-evidence OBJECT IDENTIFIER ::= {tcg-dice manifest-evidience(7) }\r\ntcg-dice-MultiTcbInfoComp OBJECT IDENTIFIER ::= {tcg-dice multitcbinfocomp(8) }\r\ntcg-dice-conceptual-message-wrapper OBJECT IDENTIFIER ::= { tcg-dice cmw(9) }\r\n\r\nDiceConceptualMessageWrapper ::= SEQUENCE {\r\n cmw OCTECT STRING\r\n}\r\n\r\nDiceTcbInfo ::== SEQUENCE {\r\n vendor [0] IMPLICIT UTF8String OPTIONAL,\r\n model [1] IMPLICIT UTF8String OPTIONAL,\r\n version [2] IMPLICIT UTF8String OPTIONAL,\r\n svn [3] IMPLICIT INTEGER OPTIONAL,\r\n layer [4] IMPLICIT INTEGER OPTIONAL,\r\n index [5] IMPLICIT INTEGER OPTIONAL,\r\n fwids [6] IMPLICIT FWIDLIST OPTIONAL,\r\n flags [7] IMPLICIT OperationalFlags OPTIONAL,\r\n vendorInfo [8] IMPLICIT OCTET STRING OPTIONAL,\r\n type [9] IMPLICIT OCTET STRING OPTIONAL,\r\n flagsMask [10]IMPLICIT OperationalFlagsMask OPTIONAL\r\n}\r\n\r\nFWIDLIST ::== SEQUENCE SIZE (1..MAX) OF FWID\r\n FWID ::== SEQUENCE {\r\n hashAlg OBJECT IDENTIFIER,\r\n digest OCTET STRING\r\n}\r\n\r\nOperationalFlags ::= BIT STRING {\r\n notConfigured (0),\r\n notSecure (1),\r\n recovery (2),\r\n debug (3),\r\n notReplayProtected (4),\r\n notIntegrityProtected (5),\r\n notRuntimeMeasured (6),\r\n notImmutable (7),\r\n notTcb (8),\r\n fixedWidth (31)\r\n}\r\n\r\nOperationalFlagsMask ::= BIT STRING {\r\n notConfigured (0),\r\n notSecure (1),\r\n recovery (2),\r\n debug (3),\r\n notReplayProtected (4),\r\n notIntegrityProtected (5),\r\n notRuntimeMeasured (6),\r\n notImmutable (7),\r\n notTcb (8),\r\n fixedWidth (31)\r\n}\r\n \r\nEND\r\n```",
"createdAt": "2024-09-24T18:45:34Z",
"updatedAt": "2024-09-24T18:59:49Z"
},
{
"author": "nedmsmith",
"authorAssociation": "COLLABORATOR",
"body": "Fixed in PR #160 ",
"createdAt": "2024-09-26T17:57:52Z",
"updatedAt": "2024-09-26T17:57:52Z"
}
]
},
Expand Down Expand Up @@ -2009,7 +2024,7 @@
"labels": [],
"body": "",
"createdAt": "2024-09-23T16:23:40Z",
"updatedAt": "2024-09-23T16:29:07Z",
"updatedAt": "2024-09-26T18:19:36Z",
"closedAt": null,
"comments": [
{
Expand All @@ -2018,6 +2033,13 @@
"body": "https://github.com/lamps-wg/csr-attestation/issues/155\r\n",
"createdAt": "2024-09-23T16:29:06Z",
"updatedAt": "2024-09-23T16:29:06Z"
},
{
"author": "nedmsmith",
"authorAssociation": "COLLABORATOR",
"body": "Fixed in PR #160 ",
"createdAt": "2024-09-26T18:19:34Z",
"updatedAt": "2024-09-26T18:19:34Z"
}
]
},
Expand All @@ -2036,9 +2058,17 @@
"labels": [],
"body": "Change the description to match what is in the TCG registry.",
"createdAt": "2024-09-23T16:35:22Z",
"updatedAt": "2024-09-23T16:35:23Z",
"updatedAt": "2024-09-26T17:57:20Z",
"closedAt": null,
"comments": []
"comments": [
{
"author": "nedmsmith",
"authorAssociation": "COLLABORATOR",
"body": "Fixed in PR #160 ",
"createdAt": "2024-09-26T17:57:19Z",
"updatedAt": "2024-09-26T17:57:19Z"
}
]
}
],
"pulls": [
Expand Down Expand Up @@ -7494,13 +7524,39 @@
"labels": [],
"body": "Updated DICE examples to create a evidence bundle containing a DICE cmw and DiceTcbInfo. Added CsrAttestation name to the definition in CSR-ATTESTATION-2023.asn file so that imports would compile.",
"createdAt": "2024-09-25T21:34:28Z",
"updatedAt": "2024-09-25T21:34:28Z",
"updatedAt": "2024-09-26T18:19:11Z",
"baseRepository": "lamps-wg/csr-attestation",
"baseRefName": "main",
"baseRefOid": "8242ad75210d973485ea1653c73a3dc57b4dc9c9",
"headRepository": "lamps-wg/csr-attestation",
"headRefName": "fix-dice-bundle-example",
"headRefOid": "20984536470a4df76e7fece65df04425146abeb2",
"headRefOid": "17d69f05b137ce8f5ef7246ccdafbe0e72c57299",
"closedAt": null,
"mergedAt": null,
"mergedBy": null,
"mergeCommit": null,
"comments": [],
"reviews": []
},
{
"number": 161,
"id": "PR_kwDOJ3IIN859AZQg",
"title": "minor wordsmithing to section 4.2",
"url": "https://github.com/lamps-wg/csr-attestation/pull/161",
"state": "OPEN",
"author": "carl-wallace",
"authorAssociation": "NONE",
"assignees": [],
"labels": [],
"body": "",
"createdAt": "2024-09-28T21:43:40Z",
"updatedAt": "2024-09-28T21:43:40Z",
"baseRepository": "lamps-wg/csr-attestation",
"baseRefName": "main",
"baseRefOid": "8242ad75210d973485ea1653c73a3dc57b4dc9c9",
"headRepository": "carl-wallace/csr-attestation",
"headRefName": "main",
"headRefOid": "248909a3689337f36944a33b8715ff10c0d3ff31",
"closedAt": null,
"mergedAt": null,
"mergedBy": null,
Expand Down

0 comments on commit d19575c

Please sign in to comment.