Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes to Instance$track() #89

Merged
merged 4 commits into from
Nov 20, 2024
Merged

Minor fixes to Instance$track() #89

merged 4 commits into from
Nov 20, 2024

Conversation

lazappi
Copy link
Collaborator

@lazappi lazappi commented Nov 20, 2024 •
edited
Loading

Description

  • Swap argument order in Instance$track() to match Python
  • Improve Python error handling in Instance$track()

Checklist

Before review

  • Update and regenerate man pages
  • Add/update tests
  • Add/update examples in vignettes
  • Pass CI checks

Before merge

  • Update architecture vignette
  • Update development vignette
  • Update features in README
  • Update CHANGELOG

@lazappi lazappi requested a review from rcannood November 20, 2024 13:51
rcannood
rcannood approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rcannood rcannood merged commit c43aec6 into main Nov 20, 2024
7 checks passed
@rcannood rcannood deleted the track-fixes branch November 20, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcannood rcannood rcannood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lazappi @rcannood