Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 Check attaching to environment in install_lamindb() #135

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

lazappi
Copy link
Collaborator

@lazappi lazappi commented Jan 8, 2025

Related to:

Description

Try to attach the created environment in install_lamindb() and give feedback if not successful.

Checklist

Before review

  • Update and regenerate man pages
  • Add/update tests
  • Add/update examples in vignettes
  • Pass CI checks

Before merge

  • Update architecture vignette
  • Update development vignette
  • Update features in README
  • Update CHANGELOG

Copy link
Collaborator

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor suggestion

R/install.R Outdated Show resolved Hide resolved
@rcannood rcannood merged commit e8c801c into main Jan 8, 2025
2 of 7 checks passed
@rcannood rcannood deleted the check-env-after-install branch January 8, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants