Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🥅 Clear error on running track in an interactive session #2334

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

Koncopd
Copy link
Member

@Koncopd Koncopd commented Jan 9, 2025

Copy link

github-actions bot commented Jan 9, 2025

@github-actions github-actions bot temporarily deployed to pull request January 9, 2025 15:58 Inactive
@Koncopd Koncopd merged commit aa2470d into main Jan 9, 2025
15 checks passed
@Koncopd Koncopd deleted the err_interactive branch January 9, 2025 16:15
@@ -49,7 +49,7 @@ jupyter = [
"mistune!=3.1.0", # there is a bug in it
]
zarr = [
"zarr>=2.16.0",
"zarr>=2.16.0,<3.0.0a0", # not yet compatible with 3.0.*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should mention somewhere that people can actually run zarr v3; they just won't be able to use anndata zarr streaming internals.

It's perfectly fine to use zarr v3 artifacts like I'm sure many people will do. But given this is an extra it might not be too confusing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad you put in the work long ago to separate this from the core package & dependencies, @Koncopd

Copy link
Member Author

@Koncopd Koncopd Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, they actually can't use zarr v3, the imports will error. Actually i think i even should add some additional version check to avoid that if zarr v3 is installed already.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets continue here #2334

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.77%. Comparing base (2a17099) to head (0e934cf).
Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
lamindb/core/_context.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2334      +/-   ##
==========================================
- Coverage   92.82%   85.77%   -7.05%     
==========================================
  Files          55       80      +25     
  Lines        7202     8624    +1422     
==========================================
+ Hits         6685     7397     +712     
- Misses        517     1227     +710     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants