-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🥅 Clear error on running track in an interactive session #2334
Conversation
@@ -49,7 +49,7 @@ jupyter = [ | |||
"mistune!=3.1.0", # there is a bug in it | |||
] | |||
zarr = [ | |||
"zarr>=2.16.0", | |||
"zarr>=2.16.0,<3.0.0a0", # not yet compatible with 3.0.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should mention somewhere that people can actually run zarr v3; they just won't be able to use anndata zarr streaming internals.
It's perfectly fine to use zarr v3 artifacts like I'm sure many people will do. But given this is an extra it might not be too confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad you put in the work long ago to separate this from the core package & dependencies, @Koncopd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, they actually can't use zarr v3
, the imports will error. Actually i think i even should add some additional version check to avoid that if zarr v3
is installed already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets continue here #2334
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2334 +/- ##
==========================================
- Coverage 92.82% 85.77% -7.05%
==========================================
Files 55 80 +25
Lines 7202 8624 +1422
==========================================
+ Hits 6685 7397 +712
- Misses 517 1227 +710 ☔ View full report in Codecov by Sentry. |
Fix https://github.com/laminlabs/pfizer-lamin-usage/issues/109
Also upper bound
zarr
.