Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Add ruff notebook formatting & remove F401 ignore #2327

Merged
merged 6 commits into from
Jan 7, 2025

Conversation

Zethson
Copy link
Member

@Zethson Zethson commented Jan 7, 2025

  • Updates our ruff pre-commit check version which now also formats and lints notebooks
  • Fixed some minor issues in our notebooks that Ruff found
  • Removes the F401 ignore

@Zethson Zethson marked this pull request as ready for review January 7, 2025 11:23
@Zethson Zethson changed the title 🎨 Add ruff notebook formatting 🎨 Add ruff notebook formatting & remove F401 ignore Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.47%. Comparing base (2a17099) to head (6beb36a).
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2327      +/-   ##
==========================================
- Coverage   92.82%   92.47%   -0.35%     
==========================================
  Files          55       80      +25     
  Lines        7202     8610    +1408     
==========================================
+ Hits         6685     7962    +1277     
- Misses        517      648     +131     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: zethson <[email protected]>
Copy link

github-actions bot commented Jan 7, 2025

@github-actions github-actions bot temporarily deployed to pull request January 7, 2025 13:15 Inactive
@Zethson Zethson merged commit 684bd38 into main Jan 7, 2025
16 of 17 checks passed
@Zethson Zethson deleted the feature/ruff_format_nbs branch January 7, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant