-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Only map synonyms when field is name #2312
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2312 +/- ##
==========================================
- Coverage 92.82% 85.64% -7.19%
==========================================
Files 55 81 +26
Lines 7202 8559 +1357
==========================================
+ Hits 6685 7330 +645
- Misses 517 1229 +712 ☔ View full report in Codecov by Sentry. |
Great! Just can you add more color to the description of the PR with a small example so that everybody reading this understands what's changing? It's even quite hard for me (even though I figured it out). One reason is also that the PR title isn't descriptive enough. Can you please improve it? Maybe just the one you mentioned here: #2137 (comment) |
Thanks for the example! But: What about the incomprehensible PR title that will also appear in the changelog? And: What about the grammatical error in this sentence: "This PR makes sure that standardize only performs on name field." And: What does the example illustrate? I mean, what was the behavior before and what after the change, @sunnyosun? |
The example shows synonyms are only mapped when field is "symbol", not "ensembl_gene_id". I don't think "This PR makes sure that standardize only performs on name field." has grammar error. |
Prevents mistakes like: #2137
Previously, synonym mapping was always performed no matter which field it was in.
This PR makes sure that synonyms are only mapped on the
name
field, e.g.,bt.Gene.symbol