Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Fix EHRCurator warning & validation #2230

Merged
merged 4 commits into from
Nov 28, 2024
Merged

Conversation

Zethson
Copy link
Member

@Zethson Zethson commented Nov 28, 2024

Fixes #2229

Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.91%. Comparing base (c54f99f) to head (3b2d4ab).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2230      +/-   ##
==========================================
+ Coverage   92.36%   92.91%   +0.54%     
==========================================
  Files          54       54              
  Lines        6566     6650      +84     
==========================================
+ Hits         6065     6179     +114     
+ Misses        501      471      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 28, 2024

@github-actions github-actions bot temporarily deployed to pull request November 28, 2024 19:12 Inactive
@Zethson Zethson changed the title 🎨 Fix EHRCurator warning 🎨 Fix EHRCurator warning & validation Nov 28, 2024
Signed-off-by: zethson <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request November 28, 2024 19:29 Inactive
@Zethson Zethson marked this pull request as ready for review November 28, 2024 19:30
@Zethson Zethson merged commit 65d4531 into main Nov 28, 2024
16 checks passed
@Zethson Zethson deleted the fix/ehrcurator_warning branch November 28, 2024 19:30
@falexwolf
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚸 Whole bunch of ugly warnings in ehrcurator
2 participants