-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Enable features with dtype = 'str'
#2226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falexwolf
changed the title
✨ Refactor features and allow str dtype
✨ Enable features width Nov 28, 2024
dtype = 'str'
falexwolf
requested review from
sunnyosun and
Zethson
and removed request for
sunnyosun
November 28, 2024 13:18
Zethson
reviewed
Nov 28, 2024
Zethson
changed the title
✨ Enable features width
✨ Enable features with Nov 28, 2024
dtype = 'str'
dtype = 'str'
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2226 +/- ##
==========================================
+ Coverage 92.36% 92.90% +0.53%
==========================================
Files 54 54
Lines 6566 6662 +96
==========================================
+ Hits 6065 6189 +124
+ Misses 501 473 -28 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
dtype="str"
dtype="number"
got renamed todtype="num"
dtype
, you'll get an errorThe valid feature dtypes are now:
In addition, specifications like
cat[ULabel]
orcat[bionty.CellType]
continue to be valid.Features with
dtype="str"
do not get annotated with values on the observation-levelAnnotate a dataset with feature values via
features.add_values()
as with all other dtypes.Observation-level annotations with values can only be achieved through the
Curator
flow. Unlike for categorical dtypes, but analogously to numerical and boolean dtypes, values do not get annotated.Example: The values for
"sample_note"
do not occur under "describe()". The feature only appears as part of the feature set that characterizes the dataset.Docs changes
Comprehensive example
Create a comprehensive test schema that covers the new dtype
"str"
:Build a test case:
Validate the description of this test dataset:
Materials
Resolves: