Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 Improve UX of db$track() and db$finish() #2213

Merged
merged 22 commits into from
Dec 1, 2024
Merged

🚸 Improve UX of db$track() and db$finish() #2213

merged 22 commits into from
Dec 1, 2024

Conversation

falexwolf
Copy link
Member

@falexwolf falexwolf commented Nov 25, 2024

The interactive notebook workflow that people use with RStudio now work as smoothly as with Jupyter notebooks.

Enables:

Resolves:

Needs:

@falexwolf falexwolf changed the title ✨ Support auto-knitted html reports with .nb.html suffix during ln.fi… ✨ Support auto-knitted html reports during ln.finish() Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.94%. Comparing base (c54f99f) to head (bbeca00).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
lamindb/_finish.py 90.90% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2213      +/-   ##
==========================================
+ Coverage   92.36%   92.94%   +0.57%     
==========================================
  Files          54       54              
  Lines        6566     6849     +283     
==========================================
+ Hits         6065     6366     +301     
+ Misses        501      483      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 25, 2024

@github-actions github-actions bot temporarily deployed to pull request November 25, 2024 11:26 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 27, 2024 11:41 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 29, 2024 10:23 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 29, 2024 10:39 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 1, 2024 17:55 Inactive
@falexwolf falexwolf changed the title ✨ Support auto-knitted html reports during ln.finish() 🚸 Improve UX of db$track() and db$finish() Dec 1, 2024
@github-actions github-actions bot temporarily deployed to pull request December 1, 2024 22:57 Inactive
@falexwolf falexwolf merged commit d9f84e4 into main Dec 1, 2024
15 of 16 checks passed
@falexwolf falexwolf deleted the autoknit branch December 1, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant