Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚚 Deprecate Curate in favor of Curator and make CuratorBase the base class of DataFrameCurator #1864

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

sunnyosun
Copy link
Member

@sunnyosun sunnyosun commented Aug 28, 2024

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.27%. Comparing base (a681d69) to head (4678d24).
Report is 3 commits behind head on main.

Files Patch % Lines
lamindb/_curate.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1864      +/-   ##
==========================================
- Coverage   92.30%   92.27%   -0.03%     
==========================================
  Files          52       52              
  Lines        5886     5893       +7     
==========================================
+ Hits         5433     5438       +5     
- Misses        453      455       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@falexwolf falexwolf changed the title 💚 Fix docs 🎨 Make Curator the base class of DataFrameCurator Aug 28, 2024
@falexwolf falexwolf changed the title 🎨 Make Curator the base class of DataFrameCurator 🎨 Make CuratorBase the base class of DataFrameCurator Aug 28, 2024
@falexwolf falexwolf changed the title 🎨 Make CuratorBase the base class of DataFrameCurator 🎨 Rename Curate to Curator and make CuratorBase the base class of DataFrameCurator Aug 28, 2024
@falexwolf falexwolf changed the title 🎨 Rename Curate to Curator and make CuratorBase the base class of DataFrameCurator 🚚 Deprecate Curate in favor of Curator and make CuratorBase the base class of DataFrameCurator Aug 28, 2024
@falexwolf falexwolf merged commit e966aea into main Aug 28, 2024
10 checks passed
@falexwolf falexwolf deleted the fix-docs branch August 28, 2024 12:36
Copy link

@github-actions github-actions bot temporarily deployed to pull request August 28, 2024 12:42 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants