-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚸 Enable versioning artifacts based on key
akin to the AWS S3 behavior
#1839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1839 +/- ##
==========================================
- Coverage 92.33% 92.26% -0.07%
==========================================
Files 52 52
Lines 5886 5912 +26
==========================================
+ Hits 5435 5455 +20
- Misses 451 457 +6 ☔ View full report in Codecov by Sentry. |
falexwolf
changed the title
🚚 Rename is_new_version_of to revises
🚸 Enable versioning artifacts based on Aug 23, 2024
key
akin to the AWS S3 behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
Artifact
, you can now also create revisions by passing thekey
argument.We're no longer auto-creating "semantic versions", but make labeling with the semantic version optional.
More intuitive signature because
version
is gone andis_new_version_of
has a more concise name:revises
.Technical changes:
is_new_version_of
argument in favor ofrevises
version
to constructors; rather set.version
after creating recordsversion
tag, auto-increment theruid
insteadis_new_version_of
torevises
lnschema-core#423Notion work package: https://www.notion.so/laminlabs/Simplify-versioning-in-LaminDB-8ef6fc7bfbdc44aca7c8dc672d611dc2
Issue:
is_new_version_of
torevises
in a backward-compatible way #1831