Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 Enable versioning artifacts based on key akin to the AWS S3 behavior #1839

Merged
merged 29 commits into from
Aug 23, 2024

Conversation

falexwolf
Copy link
Member

@falexwolf falexwolf commented Aug 23, 2024

For Artifact, you can now also create revisions by passing the key argument.

image

We're no longer auto-creating "semantic versions", but make labeling with the semantic version optional.

image

More intuitive signature because version is gone and is_new_version_of has a more concise name: revises.

before after
image image

Technical changes:

Notion work package: https://www.notion.so/laminlabs/Simplify-versioning-in-LaminDB-8ef6fc7bfbdc44aca7c8dc672d611dc2

Issue:

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 7 lines in your changes missing coverage. Please review.

Project coverage is 92.26%. Comparing base (902769a) to head (53d3446).
Report is 4 commits behind head on main.

Files Patch % Lines
lamindb/_artifact.py 89.74% 4 Missing ⚠️
lamindb/_transform.py 83.33% 2 Missing ⚠️
lamindb/_record.py 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1839      +/-   ##
==========================================
- Coverage   92.33%   92.26%   -0.07%     
==========================================
  Files          52       52              
  Lines        5886     5912      +26     
==========================================
+ Hits         5435     5455      +20     
- Misses        451      457       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Aug 23, 2024

@github-actions github-actions bot temporarily deployed to pull request August 23, 2024 05:07 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 23, 2024 07:57 Inactive
@falexwolf falexwolf changed the title 🚚 Rename is_new_version_of to revises 🚸 Enable versioning artifacts based on key akin to the AWS S3 behavior Aug 23, 2024
@github-actions github-actions bot temporarily deployed to pull request August 23, 2024 15:22 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 23, 2024 15:53 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 23, 2024 16:51 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 23, 2024 17:20 Inactive
@falexwolf falexwolf merged commit f353217 into main Aug 23, 2024
10 checks passed
@falexwolf falexwolf deleted the versioning branch August 23, 2024 17:37
@github-actions github-actions bot temporarily deployed to pull request August 23, 2024 17:46 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant