Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix var_index validation #1790

Merged
merged 15 commits into from
Aug 6, 2024
Merged

🐛 Fix var_index validation #1790

merged 15 commits into from
Aug 6, 2024

Conversation

sunnyosun
Copy link
Member

@sunnyosun sunnyosun commented Aug 5, 2024

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 81.73077% with 19 lines in your changes missing coverage. Please review.

Project coverage is 92.01%. Comparing base (9a85e27) to head (06637dd).
Report is 6 commits behind head on main.

Files Patch % Lines
lamindb/_curate.py 80.64% 18 Missing ⚠️
lamindb/core/_feature_manager.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1790      +/-   ##
==========================================
- Coverage   92.19%   92.01%   -0.18%     
==========================================
  Files          51       51              
  Lines        5598     5687      +89     
==========================================
+ Hits         5161     5233      +72     
- Misses        437      454      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Aug 5, 2024

@github-actions github-actions bot temporarily deployed to pull request August 5, 2024 15:44 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 5, 2024 16:20 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 6, 2024 09:00 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 6, 2024 09:26 Inactive
@Zethson Zethson mentioned this pull request Aug 6, 2024
@github-actions github-actions bot temporarily deployed to pull request August 6, 2024 15:29 Inactive
@sunnyosun sunnyosun merged commit 9f8e2a8 into main Aug 6, 2024
13 of 15 checks passed
@sunnyosun sunnyosun deleted the validate-var-index branch August 6, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider negative examples for curate
1 participant