Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Track write operations on array stores #1756

Merged
merged 22 commits into from
Aug 2, 2024
Merged

✨ Track write operations on array stores #1756

merged 22 commits into from
Aug 2, 2024

Conversation

Koncopd
Copy link
Member

@Koncopd Koncopd commented Jul 26, 2024

Artifacts that store mutable arrays behave much like databases. A query of the "same artifact" won't lead the same result upon it's mutation.

For better reproducibility, this PR introduces tracking such mutations when a context manager and Artifact.open() is used.

with artifact.open():
    # mutate artifact
    
# artifact now points to a new version of the artifact with an updated hash  

Use case:

@falexwolf falexwolf changed the title ✨ Track writes in backed mode ✨ Track write operations during streaming Jul 30, 2024
@falexwolf falexwolf changed the title ✨ Track write operations during streaming ✨ Track write operations on array stores Jul 31, 2024
@Koncopd Koncopd force-pushed the track_writes branch 2 times, most recently from 22e51be to 7dd2800 Compare August 2, 2024 10:02
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 88.44221% with 69 lines in your changes missing coverage. Please review.

Project coverage is 92.19%. Comparing base (2aef0a2) to head (b2f91c6).
Report is 18 commits behind head on main.

Files Patch % Lines
lamindb/core/storage/_anndata_accessor.py 88.11% 60 Missing ⚠️
lamindb/core/storage/_backed_access.py 86.88% 8 Missing ⚠️
lamindb/core/_feature_manager.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1756      +/-   ##
==========================================
+ Coverage   91.89%   92.19%   +0.30%     
==========================================
  Files          50       51       +1     
  Lines        5525     5587      +62     
==========================================
+ Hits         5077     5151      +74     
+ Misses        448      436      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Aug 2, 2024

@github-actions github-actions bot temporarily deployed to pull request August 2, 2024 15:53 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 2, 2024 16:09 Inactive
@Koncopd Koncopd merged commit d369754 into main Aug 2, 2024
14 of 15 checks passed
@Koncopd Koncopd deleted the track_writes branch August 2, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant