-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Track write operations on array stores #1756
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falexwolf
changed the title
✨ Track writes in backed mode
✨ Track write operations during streaming
Jul 30, 2024
falexwolf
changed the title
✨ Track write operations during streaming
✨ Track write operations on array stores
Jul 31, 2024
Koncopd
force-pushed
the
track_writes
branch
2 times, most recently
from
August 2, 2024 10:02
22e51be
to
7dd2800
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1756 +/- ##
==========================================
+ Coverage 91.89% 92.19% +0.30%
==========================================
Files 50 51 +1
Lines 5525 5587 +62
==========================================
+ Hits 5077 5151 +74
+ Misses 448 436 -12 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Artifacts that store mutable arrays behave much like databases. A query of the "same artifact" won't lead the same result upon it's mutation.
For better reproducibility, this PR introduces tracking such mutations when a context manager and
Artifact.open()
is used.Use case: