Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Fix validator #1513

Merged
merged 4 commits into from
Mar 21, 2024
Merged

🎨 Fix validator #1513

merged 4 commits into from
Mar 21, 2024

Conversation

sunnyosun
Copy link
Member

No description provided.

Copy link

github-actions bot commented Mar 20, 2024

@github-actions github-actions bot temporarily deployed to pull request March 20, 2024 20:32 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 20, 2024 20:49 Inactive
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 65.71429% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 92.95%. Comparing base (7ffed2e) to head (6b8a2ab).
Report is 4 commits behind head on main.

Files Patch % Lines
lamindb/validation/_register.py 61.90% 8 Missing ⚠️
lamindb/validation/_anndata_validator.py 50.00% 3 Missing ⚠️
lamindb/validation/_validator.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1513      +/-   ##
==========================================
- Coverage   93.13%   92.95%   -0.18%     
==========================================
  Files          52       52              
  Lines        4862     4881      +19     
==========================================
+ Hits         4528     4537       +9     
- Misses        334      344      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunnyosun sunnyosun merged commit d6e2751 into main Mar 21, 2024
11 of 13 checks passed
@sunnyosun sunnyosun deleted the fix-validator branch March 21, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant