adding the ability to output the dataset #1502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding the ability to output the dataset (this is useful for removing batch effects)
falexwolf
reviewed
Mar 15, 2024
| @@ -79,6 +79,7 @@ def __init__( | |||
| unknown_label: Optional[Union[str, Dict[str, str]]] = None, | |||
| cache_categories: bool = True, | |||
| parallel: bool = False, | |||
| add_dataset_id: bool = False, | |||
There was a problem hiding this comment.
@Koncopd - I don't fully understand what this does, but likely it deserves a better name.
|
Hm, maybe return this by default without any additional arguments? As we return a dict now, it is not a problem if we add some additinal keys. |
|
Sounds like the right thing, Sergei! |
|
@jkobject are you fine with the suggestion? I can do this myself or you can change it here - just by removing the argument |
|
Works with me! |
|
done here #1504 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Sergey, Alex,
I just realized I had made one more update to .mapped() in which I am adding the ability to output the dataset. I need it to remove batch effects in my model like scGPT does.
Let me know if that is ok. Once this is updated I can use this version :)