feat(eigenda-client-m1): Add validators #380
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
juan518munoz
reviewed
Jan 3, 2025
Comment on lines
55
to
58
| L1Network::Sepolia | L1Network::Holesky => { | ||
| Some(Address::from_str("0xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa").unwrap()) | ||
| //TODO: add real address | ||
| } |
There was a problem hiding this comment.
Maybe it'd be better if we set this to None like we do in the other cases (keeping the TODO comment of course).
juan518munoz
approved these changes
Jan 3, 2025
juanbono
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This PR adds eigenda l1 and l2 validator contracts
Related to: lambdaclass/era-contracts#40
Why ❔
Checklist
zkstack dev fmtandzkstack dev lint.