feat(eigen-client-pr-comments): Eigen client pr comments #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juan518munoz
reviewed
Dec 5, 2024
juan518munoz
approved these changes
Dec 5, 2024
juanbono
reviewed
Dec 6, 2024
core/lib/env_config/src/da_client.rs
Outdated
| ), | ||
| _ => anyhow::bail!("Unknown Eigen points type"), | ||
| }, | ||
| g1_link: env::var("DA_G1_LINK")?.parse()?, |
There was a problem hiding this comment.
change it to EIGENDA_G1_URL and the same for the g2 point
juanbono
reviewed
Dec 6, 2024
core/lib/env_config/src/da_client.rs
Outdated
| DA_VERIFY_CERT=false | ||
| DA_POINTS_SOURCE="Path" | ||
| DA_POINTS_PATH="resources" | ||
| DA_G1_LINK="resources1" |
juanbono
reviewed
Dec 6, 2024
core/lib/env_config/src/da_client.rs
Outdated
| wait_for_finalization: true, | ||
| authenticated: false, | ||
| verify_cert: false, | ||
| points_source: PointsSource::Path("resources".to_string()), | ||
| g1_link: "resources1".to_string(), |
juanbono
reviewed
Dec 6, 2024
| } | ||
|
|
||
| #[async_trait] | ||
| impl DataAvailabilityClient for EigenClient { | ||
| impl<T: GetBlobData + 'static> DataAvailabilityClient for EigenClient<T> { |
juanbono
reviewed
Dec 6, 2024
| use crate::utils::to_retriable_da_error; | ||
|
|
||
| #[async_trait] | ||
| pub trait GetBlobData: Clone + std::fmt::Debug + Send + Sync { |
juan518munoz
reviewed
Dec 6, 2024
Co-authored-by: juan518munoz <[email protected]>
juanbono
approved these changes
Dec 6, 2024
gianbelinche
merged commit 4bb08b9
into
eigen-client-extra-features
10 of 23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This PR fixes comments made on extra client PR
Why ❔
Checklist
zkstack dev fmtandzkstack dev lint.