feat(eigen-client-extra-features): Add option to download points #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianbelinche
changed the title
|
There are some |
juanbono
reviewed
Nov 26, 2024
Done |
juanbono
reviewed
Nov 27, 2024
| let link = required(&link.link).context("link")?; | ||
| zksync_config::configs::da_client::eigen::PointsSource::Link(link.clone()) | ||
| } | ||
| None => return Err(anyhow::anyhow!("Invalid Eigen DA configuration")), |
There was a problem hiding this comment.
why Anyhow instead of adding a proper error type?
There was a problem hiding this comment.
That is how it is done for the other clients
juanbono
approved these changes
Nov 27, 2024
juan518munoz
approved these changes
Nov 27, 2024
gianbelinche
merged commit cef9a89
into
eigen-client-extra-features
4 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This PR adds an option to download points files instead of using a path
Why ❔
Checklist
zkstack dev fmtandzkstack dev lint.