better looking format for versions (#379)

Co-authored-by: Santiago Pittella <[email protected]>
lambdaclass · Nov 24, 2023 · c84aca4 · c84aca4
1 parent 1f4fd73
commit c84aca4
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/lib/starknet_explorer_web/live/contract_live.ex b/lib/starknet_explorer_web/live/contract_live.ex
@@ -269,7 +269,7 @@ defmodule StarknetExplorerWeb.ContractDetailLive do
           <%= if is_nil(@class) do %>
             -
           <% else %>
-            <%= @class.version %>
+            <%= Utils.format_version(@class.version) %>
           <% end %>
         </span>
       </div>
@@ -314,7 +314,7 @@ defmodule StarknetExplorerWeb.ContractDetailLive do
           </div>
           <div>
             <div class="list-h">Version</div>
-            <div><%= version %></div>
+            <div><%= Utils.format_version(version) %></div>
           </div>
         </div>
       <% end %>

diff --git a/lib/starknet_explorer_web/live/pages/block_detail.ex b/lib/starknet_explorer_web/live/pages/block_detail.ex
@@ -546,7 +546,7 @@ defmodule StarknetExplorerWeb.BlockDetailLive do
         </div>
         <div>
           <div class="list-h">Version</div>
-          <div><%= version %></div>
+          <div><%= Utils.format_version(version) %></div>
         </div>
         <div>
           <div class="list-h">Status</div>

diff --git a/lib/starknet_explorer_web/live/utils.ex b/lib/starknet_explorer_web/live/utils.ex
@@ -172,4 +172,8 @@ defmodule StarknetExplorerWeb.Utils do
   def network_path(:testnet, remaining_path) do
     "/testnet/#{remaining_path}"
   end
+
+  def format_version(<<"0x", hex_val::binary>>), do: "Cairo " <> hex_val
+  def format_version(nil), do: "-"
+  def format_version(version), do: version
 end