Add sierra emulator support #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The motivation for this approach is to minimize change, and keeping the new executor isolated (eventually allowing for jit maybe?)
JulianGCalderon
force-pushed
the
add-sierra-emu
branch
from
1cd7d59 to
07c2f4e
Compare
FrancoGiachetta
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an Enum
ContractExecutorwith variantsAotandEmu. This allows to specify the desired executor from our Replay, instead of relying on feature flags.The motivation for this approach is to minimize change, and keeping the new executor isolated (eventually allowing for jit maybe?)
I think this PR should be merged as is (without adding trace dump support). This is because the trace dump support requires a different branch of Cairo Native, and would make it incompatible with the
replaybranch. Therefore, trace dump support should be implemented in a different branch, parallel to the replay branch (i.ereplay-with-trace-dump)