Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase player's amount and add new initial positions #988

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Increase player's amount and add new initial positions #988

merged 3 commits into from
Nov 14, 2024

Conversation

tvillegas98
Copy link
Contributor

@tvillegas98 tvillegas98 commented Nov 14, 2024 •
edited
Loading

Motivation

Merliot is bigger than araban, so we can support more players.

Summary of changes

How to test it?

You can explain how you tested it or suggest a way to do so.

Checklist

  • Tested the changes locally.
  • Reviewed the changes on GitHub, line by line.
  • This change requires new documentation.
    • Documentation has been added/updated.

@tvillegas98 tvillegas98 marked this pull request as ready for review November 14, 2024 20:02
@tvillegas98 tvillegas98 changed the title Increae player's amount and add new initial positions Increase player's amount and add new initial positions Nov 14, 2024
Nico-Sanchez
Nico-Sanchez requested changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@Nico-Sanchez Nico-Sanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few positions behind a wall. Can you move them to the other side of them?
Something like this:

Screenshot 2024-11-14 at 5 11 58 PM

apps/arena/lib/arena/matchmaking/game_launcher.ex Outdated Show resolved Hide resolved
@manucamejo manucamejo merged commit 83c3ccd into main Nov 14, 2024
1 check passed
@manucamejo manucamejo deleted the increase-players branch November 14, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nico-Sanchez Nico-Sanchez Nico-Sanchez approved these changes

@manucamejo manucamejo manucamejo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tvillegas98 @manucamejo @Nico-Sanchez